certificate-authority: validate identity CSRs against DB #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkralik
force-pushed
the
jkralik/feature/ca-check-device-identity-certificate
branch
2 times, most recently
from
0031d30
to
a031488
Compare
jkralik
force-pushed
the
jkralik/feature/ca-check-device-identity-certificate
branch
3 times, most recently
from
4f44f92
to
9c8efa3
Compare
| if latest.GetCredential().GetDate() > toUpdate.GetCredential().GetDate() { | ||
| toUpdate.Credential = latest.GetCredential() | ||
| } | ||
| if latest.GetCreationDate() < toUpdate.GetCreationDate() { |
There was a problem hiding this comment.
lines 115-124 are not used according to Sonar, can't we add a test case that verifies that this works properly?
jkralik
force-pushed
the
jkralik/feature/ca-check-device-identity-certificate
branch
from
69b7fb8
to
46b7996
Compare
Danielius1922
approved these changes
May 24, 2023
Is this part of our documentation? This behaviour should be documented there. |
A device or user with ill intent is unable to obtain the identity certificate that has already been signed for a different device.
jkralik
force-pushed
the
jkralik/feature/ca-check-device-identity-certificate
branch
from
46b7996
to
6cacc76
Compare
jkralik
force-pushed
the
jkralik/feature/ca-check-device-identity-certificate
branch
from
6cacc76
to
b378631
Compare
jkralik
force-pushed
the
jkralik/feature/ca-check-device-identity-certificate
branch
2 times, most recently
from
6039a03
to
b370a95
Compare
jkralik
force-pushed
the
jkralik/feature/ca-check-device-identity-certificate
branch
from
b370a95
to
1d4a97e
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A device or user with ill intent is unable to obtain the identity certificate that has already been signed for a different device.