test: add plgd time resource #934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danielius1922
approved these changes
May 4, 2023
jkralik
force-pushed
the
adam/feature/add-system-clock
branch
2 times, most recently
from
5b0c445
to
d96b54f
Compare
jkralik
force-pushed
the
adam/feature/add-system-clock
branch
from
d96b54f
to
f5fcd29
Compare
| @@ -121,6 +122,15 @@ func TestRequestHandlerGetDeviceResources(t *testing.T) { | |||
| }, | |||
| ), | |||
| }, | |||
| { | |||
| Types: []string{plgdtime.ResourceType}, | |||
There was a problem hiding this comment.
Maybe we can have a single function in the test package that generates these Change events, otherwise finding all places where they are used is difficult.
There was a problem hiding this comment.
We need to create task for that because we need to stabilize build in iotivity-lite stack. (All PRs are red now for plgd-dev/device).
There was a problem hiding this comment.
Yep, we have desynced repositories - IoTivity + hub without plgdTime, device with it. We can do it in two steps, merge this first to stabilize all repos and then the refactoring comit.
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.