Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amazon Rekognition support for PyZM #1

Merged
merged 16 commits into from
Sep 5, 2021

Conversation

mludvig
Copy link

@mludvig mludvig commented Sep 5, 2021

Offload object-detection to Amazon Rekognition service.
Removes the need for GPU or TPU on the ZoneMinder server.

pyzm/ml/object.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@pliablepixels
Copy link
Owner

Thanks for this contribution - very useful! Comments added

@mludvig
Copy link
Author

mludvig commented Sep 5, 2021

Ok, done the required changes. Hope that's all good now :)

@pliablepixels pliablepixels merged commit 3ec5e33 into pliablepixels:master Sep 5, 2021
@mludvig
Copy link
Author

mludvig commented Sep 5, 2021

Thanks, that was quick! :)
Would you mind releasing it as a new pyzm version to make things easier to refer to? I've got a pyzm-0.3.53+aws package in my github releases but it'd be better if people didn't need to install it manually.

@lucasnz
Copy link

lucasnz commented Sep 23, 2021

@mludvig I love this idea. I'm getting an error importing the module. Any ideas what might cause this?

Python 3.6.9 (default, Jan 26 2021, 15:33:00)
[GCC 8.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import pyzm.ml.aws_rekognition as awsr
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "<fstring>", line 1
    (bbox=)

@lucasnz
Copy link

lucasnz commented Sep 23, 2021

Changing line 74 to the below resolves the above issue for python 3.6 and 3.7 compatibility:
g.logger.Debug(3, f"bbox={bbox!r} / label={label!r} / conf={conf!r}")

The previous debugging format was introduced in python 3.8

@mludvig
Copy link
Author

mludvig commented Sep 23, 2021

Thanks @lucasnz I've fixed it in my repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants