-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gets confused with pydocstyle (Dxxx) violations #1
Comments
Looks to be a similar issue with flake8-print violations, at least with T001. With With |
Looks like the pydocstyle issue was taken care of, I wonder what the status for the rest of TODOs to get flake8-docstrings to cooperate is? |
Just waiting for this to get merged: https://gitlab.com/pycqa/flake8-docstrings/-/merge_requests/29 |
Fixed in flake8-docstrings v1.6.0 |
* Upgrade flake8 to 3.9.0 https://flake8.pycqa.org/en/latest/release-notes/3.9.0.html * Upgrade pydocstyle to 6.0.0 https://www.pydocstyle.org/en/latest/release_notes.html#september-13th-2020 https://www.pydocstyle.org/en/latest/release_notes.html#march-18th-2021 * Upgrade flake8-docstrings to 1.6.0, enable flake8-noqa https://gitlab.com/pycqa/flake8-docstrings/-/blob/1.6.0/HISTORY.rst plinss/flake8-noqa#1 * Upgrade/pin pyflakes to 2.3.1 https://github.com/PyCQA/pyflakes/blob/2.3.1/NEWS.rst * Pin pycodestyle to 2.7.0
Are there any recommendations on how to handle this when not using a flake8 integration for |
If a line has a Dxxx violation and you add a
# noqa: Dxxx
flake-noqa starts complaining that Dxxx isn't matched on that line.This is due to the fact that pydocstyle parses the
# noqa
comment itself and never sends the violation report to flake8, so flake8-noqa stops seeing it.Issue filed on pydocstyle to add a
--disable-noqa
equivalent, and will be followed by an issue on flake8-docstyle to invoke the option. Note the same issue also affectsflake8 --disable-noqa
, it still won't show violations reported by pydocstyle and blocked by# noqa
comments regardless if this plugin is used or not.Should the issues on pydocstyle and flake8-docstyle be rejected, will look for some kind of less-than-ideal workaround.
The text was updated successfully, but these errors were encountered: