Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SMS-6010: Add DLT Params to Send and Get Message APIs #307

Merged
merged 4 commits into from
Aug 3, 2023
Merged

SMS-6010: Add DLT Params to Send and Get Message APIs #307

merged 4 commits into from
Aug 3, 2023

Conversation

mohsin-plivo
Copy link
Contributor

@mohsin-plivo mohsin-plivo commented Jul 11, 2023 •
edited
Loading

aayush-plivo
aayush-plivo approved these changes Jul 18, 2023
View reviewed changes
Copy link

@aayush-plivo aayush-plivo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Shouldn't there be some changelog/version related changes on this?

@mohsin-plivo
Copy link
Contributor Author

LGTM. Shouldn't there be some changelog/version related changes on this?

Yes, Haven't added the changelog and version related changes on any of the SDK PRs yet. Since they don't impact the working, I plan to add those after QA is done to ensure the version change is up to date.

If we add right now, there might be some releases between today and QA complete making the version changes made right now obselete

@aayush-plivo
Copy link

LGTM. Shouldn't there be some changelog/version related changes on this?

Yes, Haven't added the changelog and version related changes on any of the SDK PRs yet. Since they don't impact the working, I plan to add those after QA is done to ensure the version change is up to date.

If we add right now, there might be some releases between today and QA complete making the version changes made right now obselete

Sure. Makes sense. Thanks.

@renoldthomas-plivo renoldthomas-plivo merged commit 03771d2 into master Aug 3, 2023
7 checks passed
@renoldthomas-plivo renoldthomas-plivo deleted the SMS-6010 branch August 3, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saurabhnewatiya-plivo saurabhnewatiya-plivo saurabhnewatiya-plivo approved these changes

@aayush-plivo aayush-plivo aayush-plivo approved these changes

@Vishnukumarpg Vishnukumarpg Vishnukumarpg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mohsin-plivo @aayush-plivo @Vishnukumarpg @saurabhnewatiya-plivo @renoldthomas-plivo