Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Faraday to v 1.0 #124

Closed
AxelTheGerman opened this issue Mar 22, 2020 · 3 comments
Closed

Upgrade Faraday to v 1.0 #124

AxelTheGerman opened this issue Mar 22, 2020 · 3 comments

Comments

@AxelTheGerman
Copy link

Faraday is used in this gem and locked to 0.x - other gems use Faraday as well and start requiring 1.x

Doesn't seem like there are many breaking changes in this release, see https://github.com/lostisland/faraday/blob/master/CHANGELOG.md#v10
However, I don't know much about Faraday so not sure what is required to upgrade plivo - or if it maybe could work with 0.x and 1.x of faraday.

Going forward this will cause more and more conflicts with other gems, i.e. preventing Plivo users from upgrading those other gems. This will get even worse if an update is required for a new feature or security fixes in those gems.

Thanks!

@AxelTheGerman
Copy link
Author

AxelTheGerman commented Jun 13, 2020

@nixonsam the plivo gem is still the only one on my Gemfile preventing me from upgrading to faraday 1.x - any update on this? Is this too much effort or needs more information?

edit: looks like for the VCR folks it didn't require too many changes vcr/vcr#794

@kunal-plivo
Copy link
Contributor

@AxelTheGerman please subscribe to updates on #136

@huzaif-plivo
Copy link
Contributor

@AxelTheGerman The SDK is updated with the required recommendations since the release of v4.10.0. However, we recommend you try our latest version v4.15.0. Feel free to contact our support team for any further issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants