Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement direct children list view #341

Merged

Conversation

SgtPooki
Copy link
Contributor

@SgtPooki SgtPooki commented Mar 4, 2023

  • feat(listView): add tab
  • feat(listView): extremely basic list view
  • feat(listview): some basic styling
  • feat(listview): bullet icons and connectorlines
  • feat(listview): fix alignment and wrapping
  • feat(listview): coloring and styles
  • fix(listview): unstarted milestone bullets
  • feat(listview): header alignment & linkification
  • feat(listview): finishing touches on linkability and description rendering
  • feat(listview): parse description from github body
  • chore(listview): code cleanup
  • chore(listview): date sort function cleanup

fixes #120

demo: https://starmaps-git-120-feature-request-create-a-vi-1e48b6-ipfs-ignite.vercel.app/roadmap/github.com/ipfs/ipfs-gui/issues/106#list

@SgtPooki SgtPooki linked an issue Mar 4, 2023 that may be closed by this pull request
@vercel
Copy link

vercel bot commented Mar 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
starmaps ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 22, 2023 at 8:45PM (UTC)

Copy link
Collaborator

@whizzzkid whizzzkid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass looks promising. Great work! I noticed some weirdness in the error display:

weird_starmap.mov

components/RoadmapList/BulletConnector.tsx Show resolved Hide resolved
components/RoadmapList/BulletIcon.module.css Outdated Show resolved Hide resolved
components/RoadmapList/BulletConnector.module.css Outdated Show resolved Hide resolved
components/RoadmapList/BulletIcon.tsx Show resolved Hide resolved
components/RoadmapList/BulletIcon.tsx Show resolved Hide resolved
lib/parser.ts Outdated Show resolved Hide resolved
tests/unit/parser.test.ts Outdated Show resolved Hide resolved
tests/unit/parser.test.ts Outdated Show resolved Hide resolved
tests/unit/parser.test.ts Outdated Show resolved Hide resolved
tests/unit/parser.test.ts Outdated Show resolved Hide resolved
@whizzzkid
Copy link
Collaborator

#342 needs merging and rebase this ☝🏽 and it should be green.

*
* @returns {string}
*/
export const getDescription = (issueBodyText: string): string => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function getDescription has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.

@SgtPooki
Copy link
Contributor Author

@whizzzkid ready for review now. sorry for the delay.

Copy link
Collaborator

@whizzzkid whizzzkid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the build, I am still seeing this: #341 (review)

did you get an opportunity to fix this?

@SgtPooki
Copy link
Contributor Author

SgtPooki commented Mar 21, 2023

Thanks for fixing the build, I am still seeing this: #341 (review)

did you get an opportunity to fix this?

I noticed some weirdness in the error display:

@whizzzkid What's the issue? that issues show up that then go away? I assume this is because we have partial data and then more full data (i.e. no ETA, then ETA) so it adds/removes appropriately.

I think it's fine as is, but I can do skeleton loading on errorNotificationDisplay if globalLoading is still true; would that satisfy issues you have with it?

Copy link
Collaborator

@whizzzkid whizzzkid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright!

@SgtPooki SgtPooki merged commit 555e6b4 into main Mar 22, 2023
@SgtPooki SgtPooki deleted the 120-feature-request-create-a-view-that-is-list-instead-of-map branch March 22, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Create a view that is "list" instead of "map"
2 participants