Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow arbitrary data around children links #367

Merged
merged 4 commits into from
May 12, 2023
Merged

fix: allow arbitrary data around children links #367

merged 4 commits into from
May 12, 2023

Conversation

SgtPooki
Copy link
Contributor

@SgtPooki SgtPooki commented May 11, 2023 •
edited
Loading

@SgtPooki SgtPooki linked an issue May 11, 2023 that may be closed by this pull request
bug: no children found on probelab root issue #366
Closed
@vercel
Copy link

vercel bot commented May 11, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
starmaps ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2023 0:52am

@SgtPooki SgtPooki mentioned this pull request May 11, 2023
Closed
@SgtPooki
Copy link
Contributor Author

It looks like it's fixed at https://starmaps-git-366-bug-no-children-found-on-pr-1d86b1-ipfs-ignite.vercel.app/roadmap/github.com/protocol/probelab/issues/1

@SgtPooki SgtPooki requested a review from whizzzkid May 11, 2023 23:15
whizzzkid
whizzzkid requested changes May 11, 2023
View reviewed changes
Copy link
Collaborator

@whizzzkid whizzzkid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hacky 🙈 but can be improved!

lib/parser.ts Show resolved Hide resolved
lib/parser.ts Outdated Show resolved Hide resolved
@SgtPooki @whizzzkid
fix: split lines by groups of spaces
c998651 
Co-authored-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>
@SgtPooki SgtPooki requested a review from whizzzkid May 12, 2023 00:53
whizzzkid
whizzzkid approved these changes May 12, 2023
View reviewed changes
Copy link
Collaborator

@whizzzkid whizzzkid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SgtPooki SgtPooki merged commit be39102 into main May 12, 2023
@SgtPooki SgtPooki deleted the 366-bug-no-children-found-on-probelab-root-issue branch May 12, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whizzzkid whizzzkid whizzzkid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: no children found on probelab root issue
2 participants
@SgtPooki @whizzzkid