add Collection to the default_page_types setting #2955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
erral
force-pushed
the
erral-issue-182-p.a.content
branch
from
874e7a8
to
a35e461
Compare
|
@jenkins-plone-org please run jobs |
erral
force-pushed
the
erral-issue-182-p.a.content
branch
from
a35e461
to
93ac06e
Compare
|
Ups, I copied-over the file and put it in the wrong folder. Regarding the upgrade step, it might be useful indeed. I will try to do the upgrade step and report here. |
|
I prepared this: plone/plone.app.upgrade#217 I think this is my first time with an upgrade step, so a review will be welcomed :) |
|
Ah, right, an upgrade step is needed. I have added a review in your PR. |
mauritsvanrees
force-pushed
the
erral-issue-182-p.a.content
branch
from
b6ac4e0
to
ebf7490
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See plone/plone.app.content#182
Merge together: plone/plone.app.content#184