Generate absolute paths #6
Conversation
me-kell
changed the title
| {%- for key, value in cookiecutter.environment|dictsort %} | ||
| {{ key }} {{ value }} | ||
| {%- endfor %} | ||
|
|
||
| CHAMELEON_CACHE {{ cookiecutter.environment_CHAMELEON_CACHE | abspath }} | ||
| zope_i18n_compile_mo_files {{ cookiecutter.environment_zope_i18n_compile_mo_files }} |
There was a problem hiding this comment.
Here a feature is lost, adding arbitrary environment strings. So we should loop over all strings starting with environment_, right?
|
Are there any open questions or to dos? Can this PR be merged? |
As mentioned in the review, there is a feature lost and we need a solution here before merge. |
|
Actually I have no idea how to solve both requirements (on the one side to handle path variables and on the other side to use a generic loop for string based environment variables) without marking and knowing the type of the variable. One workaround could be to declare the path variables (in this case "CHAMELEON_CACHE") separated from the environment variables. Thus looping through the environment and treating them as strings and declaring CHAMELEON_CACHE separately (i.e. outside of the "environment" dictionary) and treating it as path. IMHO we pay a high price (wrong paths) for having an elegant generic handling of (at the moment) only two (actually only one if we treat CHAMELEON_CACHE separately) variables. Any idea? |
|
I integrated your branch with some modifications around environment handling into toward-2.0 branch. |
See #5 (comment)