Swagger for search #630
Swagger for search #630
Conversation
Codecov Report
@@ Coverage Diff @@
## master #630 +/- ##
==========================================
- Coverage 93.52% 93.48% -0.05%
==========================================
Files 284 284
Lines 25116 25141 +25
==========================================
+ Hits 23490 23503 +13
- Misses 1626 1638 +12
Continue to review full report at Codecov.
|
karannaoh
force-pushed
the
swagger-for-search
branch
from
42e2b9c
to
ea3de1a
Compare
guillotina/api/service.py
Outdated
| data = self.request.url.query | ||
| for parameter in self.__config__['parameters']: | ||
| if parameter['in'] == 'query': | ||
| if parameter['schema']['type'] == 'integer': |
There was a problem hiding this comment.
Could we handle KeyError here?
There was a problem hiding this comment.
keyError for parameter['schema']['type']?
There was a problem hiding this comment.
Yes, if they define a parameter without the schema defined
I imagine it already default to string so you don't need to define this.
guillotina/api/service.py
Outdated
| if parameter['in'] == 'query': | ||
| if parameter['schema']['type'] == 'integer': | ||
| try: | ||
| int(data[parameter['name']]) |
There was a problem hiding this comment.
Before all this, shouldn't we first check if name is in data?
guillotina/api/service.py
Outdated
| }) | ||
| else: | ||
| pass | ||
| if parameter['required'] and parameter['name'] not in data: |
There was a problem hiding this comment.
what if they don't define required?
Maybe the whole check should be wrapped in KeyError handling?
karannaoh
force-pushed
the
swagger-for-search
branch
from
35faae3
to
5f3654a
Compare
karannaoh
force-pushed
the
swagger-for-search
branch
from
5f3654a
to
a3d6a1c
Compare
No description provided.