Do not ignore setuptools when plone.base is installed. #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I run the coredev buildout I now get this: ``` Develop distribution: plone.portlet.static 4.0.1.dev0 uses namespace packages but the distribution does not require setuptools. Develop distribution: plone.portlet.collection 4.0.1.dev0 uses namespace packages but the distribution does not require setuptools. Develop distribution: plone.z3cform 2.0.1.dev0 uses namespace packages but the distribution does not require setuptools. Develop distribution: plone.app.querystring 2.0.2.dev0 uses namespace packages but the distribution does not require setuptools. ``` It is a [warning from buildout](buildout/buildout#526). It seems to work, but I don't trust it.
|
Oops, sorry 🙏🏾 I was eager on removing as much dependencies as possible, while declaring them all 😅 |
gforcada
approved these changes
Mar 14, 2023
|
In theory, it's no longer necessary to use setuptools to declare namespace packages: https://peps.python.org/pep-0420/ But I'm not sure what edge cases we would find in our tools if we tried to make the switch. |
|
oh, that's a long shot, as it means that we have to remove all |
|
Thanks, helpful discussion there. |
|
I have added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I run the coredev buildout I now get this:
It is a warning from buildout.
It seems to work, but I don't trust it.
See same comment I made in the PR that added this.