Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update button urls when we change context #858

Closed
wants to merge 1 commit into from
Closed

Update button urls when we change context #858

wants to merge 1 commit into from

Conversation

cekk
Copy link
Member

@cekk cekk commented Jul 13, 2018

This pr tries to fix some of the problems found in #857

This is a wip implementation.
I don't know if this is the right approach.
Especially when i try to update the current button urls.

@cekk cekk requested a review from thet July 13, 2018 07:30
@jensens jensens changed the title [WIP] - Update button urls when we change context Update button urls when we change context Jul 13, 2018
@sunew sunew mentioned this pull request Sep 19, 2018
Closed
@sunew sunew mentioned this pull request Sep 28, 2018
Closed
@thet
Copy link
Member

thet commented Oct 4, 2018

@cekk - as mentioned in #857, this will be fixed with:

@thet thet closed this Oct 4, 2018
@thet thet deleted the structure-update-button-links branch October 4, 2018 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thet thet Awaiting requested review from thet

Assignees
No one assigned
Labels
22 status: in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cekk @thet @jensens