Skip to content

Commit

Permalink
Do not add the 2.7 check to 6.0 jobs.
Browse files Browse the repository at this point in the history
  • Loading branch information
mauritsvanrees committed Apr 30, 2021
1 parent 73557e2 commit a0e35c5
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions src/mr.roboto/src/mr/roboto/subscriber.py
Original file line number Diff line number Diff line change
Expand Up @@ -385,12 +385,18 @@ def run(self):
"""Create waiting status for all pull request jobs that should be run
before a pull request can be safely merged
"""
# This may return ["5.2", "6.0"].
plone_versions = self._plone_versions_targeted()
# This WarnTestsNeedToRun check is for Python 2 only.
# The plone_versions setting in production.ini should contain only 2.7
plone_py2_versions = self.event.request.registry.settings['plone_versions']

# get the pull request last commit
last_commit = self.get_pull_request_last_commit()

for version in plone_versions:
if version not in plone_py2_versions:
continue
self._create_commit_status(last_commit, version)
self.log(f'created pending status for plone {version}')

Expand Down

1 comment on commit a0e35c5

@gforcada
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mauritsvanrees I'm looking at making the py3_versions config setting to be a dictionary, and this fix here is fine, but it fails short, as there are other places were that have to be fixed.

I'm having a look at it :)

Please sign in to comment.