replace dash with lowdash in project_name #16

MrTango · 2022-02-08T16:32:34Z

No description provided.

mister-roboto · 2022-02-08T16:32:39Z

@MrTango thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

coveralls · 2022-02-08T16:33:39Z

Pull Request Test Coverage Report for Build 1813476658

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

8 of 8 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 1807085683:	0.0%
Covered Lines:	197
Relevant Lines:	197

💛 - Coveralls

I wondered if this would need to be handled as `examplecamelcase`, so all lowercase. But it seems to work fine with camel case.

Other branches will be tested when they have a pull request. On #16 I saw 34 GitHub Actions tests, half of them for the PR, and half for a push to the branch. That is wasteful.

mauritsvanrees

LGTM, thanks!
I have updated the tests.

Can be merged once green:

@jenkins-plone-org please run jobs

Branch: refs/heads/main Date: 2022-02-08T18:34:18+02:00 Author: MrTango (MrTango) <md@derico.de> Commit: plone/plone.autoinclude@41015d8 replace dash with lowdash in project_name Files changed: A news/16.bugfix M src/plone/autoinclude/loader.py Repository: plone.autoinclude Branch: refs/heads/main Date: 2022-02-08T18:47:12+02:00 Author: MrTango (MrTango) <md@derico.de> Commit: plone/plone.autoinclude@1738f5c add example.plone-dash-addon tst Files changed: A test-packages/example.plone-dash-addon/MANIFEST.in A test-packages/example.plone-dash-addon/setup.py A test-packages/example.plone-dash-addon/src/example/__init__.py A test-packages/example.plone-dash-addon/src/example/plone_dash_addon/__init__.py A test-packages/example.plone-dash-addon/src/example/plone_dash_addon/browser/__init__.py A test-packages/example.plone-dash-addon/src/example/plone_dash_addon/browser/configure.zcml A test-packages/example.plone-dash-addon/src/example/plone_dash_addon/configure.zcml A test-packages/example.plone-dash-addon/src/example/plone_dash_addon/permissions.zcml A test-packages/example.plone-dash-addon/src/example/plone_dash_addon/tests.py Repository: plone.autoinclude Branch: refs/heads/main Date: 2022-02-08T19:53:43+02:00 Author: MrTango (MrTango) <md@derico.de> Commit: plone/plone.autoinclude@a93231d Add tests Files changed: M buildout.cfg M src/plone/autoinclude/loader.py M src/plone/autoinclude/tests/test_loader.py M test-packages/example.plone-dash-addon/setup.py M tox.ini Repository: plone.autoinclude Branch: refs/heads/main Date: 2022-02-08T20:49:45+01:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/plone.autoinclude@2983445 Update ploneintegration tests to include example.plone_dash_addon files. Files changed: M test-packages/example.ploneintegration/src/example/ploneintegration/tests.py Repository: plone.autoinclude Branch: refs/heads/main Date: 2022-02-08T20:54:01+01:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/plone.autoinclude@56b5d87 fix lint by running black Files changed: M src/plone/autoinclude/tests/test_loader.py Repository: plone.autoinclude Branch: refs/heads/main Date: 2022-02-08T21:01:32+01:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/plone.autoinclude@a9dfdd2 Fixed buildout tests for example.plone-dash-addon. Files changed: M buildout.cfg M test-packages/example.plone-dash-addon/src/example/plone_dash_addon/configure.zcml M test-packages/example.plone-dash-addon/src/example/plone_dash_addon/tests.py Repository: plone.autoinclude Branch: refs/heads/main Date: 2022-02-08T21:15:29+01:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/plone.autoinclude@30a4ad7 Add test-packages/ExampleCamelCase I wondered if this would need to be handled as `examplecamelcase`, so all lowercase. But it seems to work fine with camel case. Files changed: A test-packages/ExampleCamelCase/MANIFEST.in A test-packages/ExampleCamelCase/setup.py A test-packages/ExampleCamelCase/src/ExampleCamelCase/__init__.py A test-packages/ExampleCamelCase/src/ExampleCamelCase/configure.zcml A test-packages/ExampleCamelCase/src/ExampleCamelCase/tests.py M buildout.cfg M test-packages/example.ploneintegration/src/example/ploneintegration/tests.py M tox.ini Repository: plone.autoinclude Branch: refs/heads/main Date: 2022-02-08T21:23:01+01:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/plone.autoinclude@700c1f0 GHA: only test main branch on push. Other branches will be tested when they have a pull request. On plone/plone.autoinclude#16 I saw 34 GitHub Actions tests, half of them for the PR, and half for a push to the branch. That is wasteful. Files changed: M .github/workflows/tests.yml Repository: plone.autoinclude Branch: refs/heads/main Date: 2022-02-09T11:50:36+02:00 Author: Maik Derstappen (MrTango) <md@derico.de> Commit: plone/plone.autoinclude@a99c88f Merge pull request #16 from plone/mrtango-fix-loader-when-dash-in-projectname replace dash with lowdash in project_name Files changed: A news/16.bugfix A test-packages/ExampleCamelCase/MANIFEST.in A test-packages/ExampleCamelCase/setup.py A test-packages/ExampleCamelCase/src/ExampleCamelCase/__init__.py A test-packages/ExampleCamelCase/src/ExampleCamelCase/configure.zcml A test-packages/ExampleCamelCase/src/ExampleCamelCase/tests.py A test-packages/example.plone-dash-addon/MANIFEST.in A test-packages/example.plone-dash-addon/setup.py A test-packages/example.plone-dash-addon/src/example/__init__.py A test-packages/example.plone-dash-addon/src/example/plone_dash_addon/__init__.py A test-packages/example.plone-dash-addon/src/example/plone_dash_addon/browser/__init__.py A test-packages/example.plone-dash-addon/src/example/plone_dash_addon/browser/configure.zcml A test-packages/example.plone-dash-addon/src/example/plone_dash_addon/configure.zcml A test-packages/example.plone-dash-addon/src/example/plone_dash_addon/permissions.zcml A test-packages/example.plone-dash-addon/src/example/plone_dash_addon/tests.py M .github/workflows/tests.yml M buildout.cfg M src/plone/autoinclude/loader.py M src/plone/autoinclude/tests/test_loader.py M test-packages/example.ploneintegration/src/example/ploneintegration/tests.py M tox.ini

replace dash with lowdash in project_name

41015d8

MrTango force-pushed the mrtango-fix-loader-when-dash-in-projectname branch from 978a754 to 41015d8 Compare February 8, 2022 16:34

MrTango requested a review from mauritsvanrees February 8, 2022 16:37

MrTango and others added 6 commits February 8, 2022 18:47

add example.plone-dash-addon tst

1738f5c

Add tests

a93231d

Update ploneintegration tests to include example.plone_dash_addon files.

2983445

fix lint by running black

56b5d87

Fixed buildout tests for example.plone-dash-addon.

a9dfdd2

Add test-packages/ExampleCamelCase

30a4ad7

I wondered if this would need to be handled as `examplecamelcase`, so all lowercase. But it seems to work fine with camel case.

GHA: only test main branch on push.

700c1f0

Other branches will be tested when they have a pull request. On #16 I saw 34 GitHub Actions tests, half of them for the PR, and half for a push to the branch. That is wasteful.

mauritsvanrees force-pushed the mrtango-fix-loader-when-dash-in-projectname branch from 6a273bf to 700c1f0 Compare February 8, 2022 20:23

mauritsvanrees approved these changes Feb 8, 2022

View reviewed changes

MrTango merged commit a99c88f into main Feb 9, 2022

MrTango deleted the mrtango-fix-loader-when-dash-in-projectname branch February 9, 2022 09:50

ale-rt mentioned this pull request Feb 9, 2022

Check if safe_name should be used: #17

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

replace dash with lowdash in project_name #16

replace dash with lowdash in project_name #16

MrTango commented Feb 8, 2022

mister-roboto commented Feb 8, 2022

coveralls commented Feb 8, 2022 •

edited

Loading

mauritsvanrees left a comment

replace dash with lowdash in project_name #16

replace dash with lowdash in project_name #16

Conversation

MrTango commented Feb 8, 2022

mister-roboto commented Feb 8, 2022

coveralls commented Feb 8, 2022 • edited Loading

Pull Request Test Coverage Report for Build 1813476658

Warning: This coverage report may be inaccurate.

Details

💛 - Coveralls

mauritsvanrees left a comment

Choose a reason for hiding this comment

coveralls commented Feb 8, 2022 •

edited

Loading