-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Py23DocChecker makes test always pass on Python 2 #7
Comments
To check, simply edit
This passes on Python 2... :-) |
For the record, after disabling the
|
mauritsvanrees
added a commit
that referenced
this issue
Mar 26, 2019
mister-roboto
pushed a commit
to plone/buildout.coredev
that referenced
this issue
Mar 26, 2019
Branch: refs/heads/master Date: 2019-03-26T19:44:50+01:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/plone.indexer@8914b38 Fixed: doctests on Python 2 were not correctly checked. Fixes plone/plone.indexer#7 Files changed: A news/7.bugfix M plone/indexer/README.rst M plone/indexer/tests.py Repository: plone.indexer Branch: refs/heads/master Date: 2019-03-27T00:51:08+01:00 Author: Gil Forcada Codinachs (gforcada) <gil.gnome@gmail.com> Commit: plone/plone.indexer@3d9036e Merge pull request #8 from plone/maurits-issue-7-py23docchecker Fixed: doctests on Python 2 were not correctly checked. Files changed: A news/7.bugfix M plone/indexer/README.rst M plone/indexer/tests.py
mister-roboto
pushed a commit
to plone/buildout.coredev
that referenced
this issue
Mar 26, 2019
Branch: refs/heads/master Date: 2019-03-26T19:44:50+01:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/plone.indexer@8914b38 Fixed: doctests on Python 2 were not correctly checked. Fixes plone/plone.indexer#7 Files changed: A news/7.bugfix M plone/indexer/README.rst M plone/indexer/tests.py Repository: plone.indexer Branch: refs/heads/master Date: 2019-03-27T00:51:08+01:00 Author: Gil Forcada Codinachs (gforcada) <gil.gnome@gmail.com> Commit: plone/plone.indexer@3d9036e Merge pull request #8 from plone/maurits-issue-7-py23docchecker Fixed: doctests on Python 2 were not correctly checked. Files changed: A news/7.bugfix M plone/indexer/README.rst M plone/indexer/tests.py
mister-roboto
pushed a commit
to plone/buildout.coredev
that referenced
this issue
Mar 26, 2019
Branch: refs/heads/master Date: 2019-03-26T19:44:50+01:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/plone.indexer@8914b38 Fixed: doctests on Python 2 were not correctly checked. Fixes plone/plone.indexer#7 Files changed: A news/7.bugfix M plone/indexer/README.rst M plone/indexer/tests.py Repository: plone.indexer Branch: refs/heads/master Date: 2019-03-27T00:51:08+01:00 Author: Gil Forcada Codinachs (gforcada) <gil.gnome@gmail.com> Commit: plone/plone.indexer@3d9036e Merge pull request #8 from plone/maurits-issue-7-py23docchecker Fixed: doctests on Python 2 were not correctly checked. Files changed: A news/7.bugfix M plone/indexer/README.rst M plone/indexer/tests.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
Py23DocChecker
doctest compatibility class has a typo which basically setsgot = want
which means the doctests always pass on Python 2.The text was updated successfully, but these errors were encountered: