Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make sure target_height is at least 1px #75

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

make sure target_height is at least 1px #75

wants to merge 1 commit into from

Conversation

MrTango
Copy link
Contributor

@MrTango MrTango commented Mar 17, 2023

No description provided.

@mister-roboto
Copy link

@MrTango thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@MrTango
Copy link
Contributor Author

MrTango commented Mar 17, 2023

@jenkins-plone-org please run jobs

davisagli
davisagli reviewed Mar 17, 2023
View reviewed changes
Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an existing test that covers these branches?

@MrTango
Copy link
Contributor Author

MrTango commented Mar 21, 2023

I'll will check it write one for the issue this solves.

mauritsvanrees
mauritsvanrees reviewed Mar 21, 2023
View reviewed changes
Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change makes sense. A test would be good indeed, it is easy to get regressions in code like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauritsvanrees mauritsvanrees mauritsvanrees left review comments

@davisagli davisagli davisagli left review comments

Assignees
No one assigned
Labels
01 type: bug 13 prio: normal 23 status: testing 34 needs: tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MrTango @mister-roboto @davisagli @mauritsvanrees @jensens