Skip to content
This repository has been archived by the owner on Apr 9, 2023. It is now read-only.

Code style... #36

Closed
vangheem opened this issue Dec 6, 2016 · 3 comments
Closed

Code style... #36

vangheem opened this issue Dec 6, 2016 · 3 comments

Comments

@vangheem
Copy link
Member

vangheem commented Dec 6, 2016

Seems we're forever troubled by the zope style of naming things..

Right now, we have module level functions that are both camel case and many that are underscore.

I'm inclined to stick with the underscore way so we're more pythonic. I know this is annoying with zope tech since it uses camel case.

Thoughts?

@gforcada
Copy link
Member

gforcada commented Dec 6, 2016

💯 keeping Plone's styleguide would be cool.

For the naming conventions pep8-naming is what you are looking for :-)

And while at it yapf to not have to spend too much time fixing all the linting yourself (I'm looking forward to a webservice that creates pull requests after piping a whole project through yapf).

I could create a pull request adding all that if there's interest.

@vangheem
Copy link
Member Author

vangheem commented Dec 6, 2016

@gforcada sure! that'd be helpful

@bloodbare
Copy link
Member

Agree on the underscore python naming.

Great for the pep8-naming!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants