Remove bootstrap and development widgets #110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to have been a development step, but isn't being used anymore. Removing it cleans up the Bootstrap styling issues of issue ploomber#101. The ConnectorWidget doesn't look as good without the Bootstrap sytles; we'll try to clean that up a bit in a later commit.
This also seems to have been a development test. It wasn't breaking anything, but it still seems worth it to clean up. In the process, this tidies up imports just a little.
|
hi @rschroll, thanks for contributing to this? is this ready for review? |
|
If you want to review, I'm happy to hear your thoughts. But the connector widget is a bit ugly looking right now. I thought I'd play with the CSS a bit to see if there are early wins. But if you prefer to get this in quickly as a fix and then clean up the widget in another PR, that's reasonable too! |
|
@rschroll oh, you're right! I completely forgot that our connector widget depends on boostrap. I'd appreciate it if you can add some CSS so it looks ok. I guess JupyterLab already provides some CSS that would make this easier? but up to you! |
|
closing due to inactivity |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Remove the TableWidget and FormWidget, which seem to have been left over from early development. As a side effect, this removes Bootstrap, which had been messing up the display of a number of parts of Jupyterlab.
Issue number
Closes #101, closes #102
Checklist before requesting a review
pkgmt format