54 connector widget special chars

[bryannho]

Describe your changes

• Fixed bug that broke connect and delete button in ConnectorWidget when special characters were included in the alias:
  • In src/widgets/connector.ts, each connection's alias was being used in the ID for its connect and delete buttons. When special characters were included in the alias, this caused an exception when document.querySelector was called on the ID.
  • To fix, I added src/util/helper-functions.ts to hold a string formatting function for special characters. This will replace special characters with their ASCII values (e.g. ':' -> '58'). I applied this function to the ID's for each connection's connect and delete buttons. Now when querySelector is called, the ID is always a valid selector.

Issue number

Closes #54

Checklist before requesting a review

• Performed a self-review of my code
• Formatted my code with pkgmt format
• Added tests (when necessary).
• Added docstring documentation and update the changelog (when needed)

[bryannho]

CI seems to be failing for unknown reason, possibly related to issue #78

[edublancas]

@bryannho is this ready? don't forget to explicitly ask for a review. are you able to request reviews?

if you can't, you can tag me and say "ready for review" so I get notified

[bryannho]

@bryannho is this ready? don't forget to explicitly ask for a review. are you able to request reviews?

if you can't, you can tag me and say "ready for review" so I get notified

Apologies - this is ready to review. I marked the branch as ready but I'm not able to request reviews in the sidebar. Will tag you next time

[edublancas]

a few things are missing:

• changelog entry
• explain your solution in the PR description
• unit tests

[edublancas]

please add a docstring

[bryannho]

Added

[bryannho]

a few things are missing:

• changelog entry
• explain your solution in the PR description
• unit tests

Added changelog, PR description, and unit tests

[edublancas]

@bryannho what's the status here? are you gonna tackle the CI issue first or will you work on passing the CI here first?

[bryannho]

@bryannho what's the status here? are you gonna tackle the CI issue first or will you work on passing the CI here first?

I'm working on passing the CI here first. Once I get that done I'll mark it for your review and start working on the CI issue. Apologies I've been working through some hardware issues with my machine but I should be have this ready for review by tomorrow morning!

[edublancas]

sounds good!

[bryannho]

@edublancas I was able to get my own individual tests to work, but the PR keeps failing checks as a result of the CI issue with multiple tries. Might need to pivot to fixing the CI issue first and then come back around to this PR.