Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated CI integration testing #549

Merged
merged 8 commits into from
Jun 1, 2023

Conversation

tonykploomber
Copy link

@tonykploomber tonykploomber commented May 30, 2023

Describe your changes

Remove duplicated integration testings

Now:

  • CI - DB Integration - Cloud
  • CI - DB Integration - Local
  • CI / integration-test-live (trigger by CI / release)
  • CI / integration-test-non-live (trigger by CI / release)

Execute result:
Live:
Screenshot 2023-05-30 at 3 53 58 PM

Non-live:
Screenshot 2023-05-30 at 3 54 17 PM

Issue number

Closes #514

Checklist before requesting a review


📚 Documentation preview 📚: https://jupysql--549.org.readthedocs.build/en/549/

@tonykploomber tonykploomber marked this pull request as draft May 30, 2023 17:52
@tonykploomber tonykploomber added the allow-workflow-edits Allow edits to .github/workflows label May 30, 2023
@tonykploomber tonykploomber changed the title test-remove-duplicated-ci-live Remove duplicated CI integration-test May 30, 2023
@tonykploomber tonykploomber marked this pull request as ready for review May 30, 2023 19:55
@tonykploomber tonykploomber changed the title Remove duplicated CI integration-test Remove duplicated CI integration testing May 30, 2023
@tonykploomber
Copy link
Author

@edublancas Please review again!

@edublancas edublancas merged commit 2bc9369 into master Jun 1, 2023
@edublancas edublancas deleted the tonyk/fix-secrets-in-integration-test-live branch June 1, 2023 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
allow-workflow-edits Allow edits to .github/workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CD script not taking into account integration tests
2 participants