Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test and example for -c/--creator feature #567

Merged
merged 11 commits into from
Jun 7, 2023

Conversation

DaveOkpare
Copy link

@DaveOkpare DaveOkpare commented Jun 1, 2023

Describe your changes

Added test and example for -c/--creator feature

Issue number

Closes #131

Checklist before requesting a review


📚 Documentation preview 📚: https://jupysql--567.org.readthedocs.build/en/567/

doc/api/magic-sql.md Show resolved Hide resolved
Copy link

@edublancas edublancas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check your code, it's failing due to a linting problem

@DaveOkpare
Copy link
Author

check your code, it's failing due to a linting problem

@edublancas Thanks for the heads up, I made too many commits before reading the linting logs, should I open a new pull request to make things cleaner?

Copy link

@edublancas edublancas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to open a new PR. just ensure all tests pass

```

```{code-cell} ipython3
%sql --creator engine

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the docs are failing bc the engine variable doesn't exist

@edublancas edublancas merged commit 464082e into ploomber:master Jun 7, 2023
@edublancas
Copy link

thanks for your contribution! @DaveOkpare

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test, and document creator feature
2 participants