-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added test and example for -c/--creator feature #567
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check your code, it's failing due to a linting problem
@edublancas Thanks for the heads up, I made too many commits before reading the linting logs, should I open a new pull request to make things cleaner? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to open a new PR. just ensure all tests pass
doc/api/magic-sql.md
Outdated
``` | ||
|
||
```{code-cell} ipython3 | ||
%sql --creator engine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the docs are failing bc the engine
variable doesn't exist
thanks for your contribution! @DaveOkpare |
Describe your changes
Added test and example for -c/--creator feature
Issue number
Closes #131
Checklist before requesting a review
pkgmt format
📚 Documentation preview 📚: https://jupysql--567.org.readthedocs.build/en/567/