Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for NULLs in histogram #568

Merged

Conversation

AnirudhVIyer
Copy link

@AnirudhVIyer AnirudhVIyer commented Jun 1, 2023

Describe your changes

Added an extra filter query that skips rows with column value Null. Changed the template to accommodate the query. _histogram function does not raise a Value Error if null data spotted and plots for the non-NULL values.

Issue number

Closes #176

Checklist before requesting a review


📚 Documentation preview 📚: https://jupysql--568.org.readthedocs.build/en/568/


@edublancas
Copy link

don't forget to request a review once this is ready

@AnirudhVIyer AnirudhVIyer marked this pull request as ready for review June 1, 2023 17:29
@AnirudhVIyer
Copy link
Author

need to make changes in doc/api/magic-plot.md

@AnirudhVIyer AnirudhVIyer marked this pull request as draft June 1, 2023 18:15
@AnirudhVIyer AnirudhVIyer marked this pull request as ready for review June 1, 2023 18:46
doc/api/magic-plot.md Outdated Show resolved Hide resolved
src/sql/plot.py Outdated Show resolved Hide resolved
src/sql/plot.py Outdated Show resolved Hide resolved
src/tests/test_plot.py Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
src/tests/test_plot.py Outdated Show resolved Hide resolved
doc/api/magic-plot.md Outdated Show resolved Hide resolved
src/tests/test_plot.py Outdated Show resolved Hide resolved
@AnirudhVIyer
Copy link
Author

Sure, I will make the changes

src/sql/plot.py Outdated Show resolved Hide resolved
src/sql/plot.py Outdated Show resolved Hide resolved
src/sql/plot.py Outdated Show resolved Hide resolved
src/sql/plot.py Outdated Show resolved Hide resolved
src/tests/test_ggplot.py Outdated Show resolved Hide resolved
src/tests/test_plot.py Outdated Show resolved Hide resolved
src/tests/test_plot.py Outdated Show resolved Hide resolved
doc/api/magic-plot.md Outdated Show resolved Hide resolved
src/sql/plot.py Outdated Show resolved Hide resolved
src/sql/plot.py Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
src/tests/test_ggplot.py Outdated Show resolved Hide resolved
@neelasha23
Copy link

Added some minor comments. Please resolve merge conflicts.
Looks good otherwise

Copy link

@yafimvo yafimvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Added some notes.

We also need to make sure it works on other databases.

To test it, you can spin up a docker container, create a new connection, create a table, and run this command (or any other relevant command) - %sqlplot histogram -t my_table_with_nulls -c x --bins 2

You can see the list of our supported databases and how to connect them here.

doc/api/magic-plot.md Show resolved Hide resolved
src/sql/plot.py Outdated Show resolved Hide resolved
src/sql/plot.py Outdated Show resolved Hide resolved
src/sql/plot.py Outdated Show resolved Hide resolved
src/tests/test_plot.py Outdated Show resolved Hide resolved
src/tests/test_plot.py Outdated Show resolved Hide resolved
Copy link

@edublancas edublancas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a few open conversations. if they've been resolved, please mark them as such

@@ -2,6 +2,7 @@

## 0.7.9dev

* [Feature] Modified `histogram` command to support data with NULL values ([#176])

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this now but the format is wrong @AnirudhVIyer, it should be: (#NUMBER), not ([#NUMBER])

@edublancas edublancas changed the title 176 add null support for histograms support for NULLs in histogram Jun 7, 2023
@edublancas edublancas merged commit 93b0309 into ploomber:master Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adding support for data with NULLs in histogram
5 participants