-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for NULLs in histogram #568
support for NULLs in histogram #568
Conversation
don't forget to request a review once this is ready |
need to make changes in doc/api/magic-plot.md |
Sure, I will make the changes |
Added some minor comments. Please resolve merge conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Added some notes.
We also need to make sure it works on other databases.
To test it, you can spin up a docker container, create a new connection, create a table, and run this command (or any other relevant command) - %sqlplot histogram -t my_table_with_nulls -c x --bins 2
You can see the list of our supported databases and how to connect them here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see a few open conversations. if they've been resolved, please mark them as such
@@ -2,6 +2,7 @@ | |||
|
|||
## 0.7.9dev | |||
|
|||
* [Feature] Modified `histogram` command to support data with NULL values ([#176]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll merge this now but the format is wrong @AnirudhVIyer, it should be: (#NUMBER)
, not ([#NUMBER])
Describe your changes
Added an extra filter query that skips rows with
column
value Null. Changed the template to accommodate the query. _histogram function does not raise a Value Error if null data spotted and plots for the non-NULL values.Issue number
Closes #176
Checklist before requesting a review
pkgmt format
📚 Documentation preview 📚: https://jupysql--568.org.readthedocs.build/en/568/