-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI Fix #992
CI Fix #992
Conversation
empty tests tests duckdb version sqlglot version nox nox
matplotlib version
lint nox sqlglot version
Please review @edublancas |
@@ -469,11 +469,13 @@ def test_bar_two_col(load_data_two_col, ip): | |||
|
|||
|
|||
@_cleanup_cm() | |||
@pytest.mark.xfail(reason="Failing intermittently with DuckDB v0.10.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if duckdb is the problem, it'd be better to test with <0.10.0 and open an issue
please open the issue and then document why 0.10.0 is failing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have tagged a couple of issues in the PR description, please check if these are ok
@neelasha23 the tests are still failing: https://github.com/ploomber/jupysql/actions/runs/8007801460/job/21872791573?pr=992 |
Yes it's the clickhouse tests only. The original issue was for Pending DuckDB fixes: #994 I'm still figuring out the issue @edublancas |
Describe your changes
test_db_driver_error_raised
because the latest DuckDB release is handling these cases:Opened issues for the pending fixes:
#994
#993
Issue number
Closes #991
Checklist before requesting a review
pkgmt format
📚 Documentation preview 📚: https://jupysql--992.org.readthedocs.build/en/992/