Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
It's a silly little thing that I noticed when looking at something else. The
facet
class inggplot/facet_wrap.py
was missing theself
argument in its__init__
method. This wasn't an issue, since this class is never used directly. Only its subclass,facet_wrap
is used, which has its own functional__init__
method, which doesn't call the superclass method. Since the method supposed to do anything, I just removed it.I'm not sure why flake8 or black didn't raise a fuss about this.
Issue number
Closes #X
Checklist before requesting a review
pkgmt format
📚 Documentation preview 📚: https://jupysql--999.org.readthedocs.build/en/999/