-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: added initial stdin and stdout interactivity tests #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Significantly more work has gone into the infra of this PR. In fact, it's now its own package: |
crutchcorn
force-pushed
the
stdio-tests
branch
from
November 10, 2021 15:07
106ef12
to
97ddd62
Compare
crutchcorn
force-pushed
the
stdio-tests
branch
from
November 10, 2021 15:12
97ddd62
to
f7955bb
Compare
crutchcorn
force-pushed
the
stdio-tests
branch
from
November 23, 2021 06:44
585a5ce
to
37dadbf
Compare
This PR seems ready to go finally. I'm going to add GitHub actions support to run tests on every PR to make sure they pass before merging Worth mentioning: It's using an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on top of @evelynhathaway's work in #267
This PR builds the scaffolding to test inquirer's interactivity on the CLI level rather than going forward to mock out any of the functionality. This is the start of true e2e testing (from a user's perspective) of Plop.
I'll be adding more valid tests in the coming weeks, but this PR is now able to functionally validate user input against existing inquirer prompts