-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PlopJS 3 #293
Merged
Merged
PlopJS 3 #293
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
5ae01d3
Update ora to pick up ansi-regex security update. Fix #291
Pike d152d6d
Merge remote-tracking branch 'origin/master' into update-ora
crutchcorn 656a74f
Initial work to migrate to ESM
crutchcorn c50946e
Fix final tests
crutchcorn 84be769
Upgrade major chalk deps
crutchcorn b7db27e
Upgrade major liftoff version
crutchcorn ad7004f
Upgrade major devtool deps
crutchcorn 91b854f
Initial work to migrate to ESM node-plop
crutchcorn 020286c
Fix error occuring with nodePlop usage
crutchcorn e52feef
chore: add test for CJS, MJS, and ESM support
crutchcorn fbc8991
Improve docs regarding generator
crutchcorn 2ae322f
Upgrade README docs
crutchcorn e13a7a3
Upgrade testing library
crutchcorn 023226e
Major upgraded Liftoff typings and Chalk
crutchcorn 7391126
chore: narrow alpha testing dep
crutchcorn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
#!/bin/sh | ||
. "$(dirname "$0")/_/husky.sh" | ||
|
||
npx lint-staged | ||
npx --no-install lint-staged |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,17 @@ | ||
#!/usr/bin/env node | ||
const args = process.argv.slice(2); | ||
const { Plop, run } = require("../src/plop"); | ||
const argv = require("minimist")(args); | ||
import { Plop, run } from "../src/plop.js"; | ||
import minimist from "minimist"; | ||
const argv = minimist(args); | ||
|
||
Plop.launch( | ||
Plop.prepare( | ||
{ | ||
cwd: argv.cwd, | ||
preload: argv.preload || [], | ||
configPath: argv.plopfile, | ||
require: argv.require, | ||
completion: argv.completion, | ||
}, | ||
run | ||
function (env) { | ||
Plop.execute(env, run); | ||
} | ||
); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should narrow your engines support to node versions that support the node protocol if not changing this on build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe I already have narrowed this properly, but will make sure to double-check :)