Various python updates (plotGlPixelRatio, template dimensions, json engine, AWS Lambda) #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will provide future compatibility with the plotly.py 5.0 JSON engine, and accelerated orjson encoder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bundles several fixes and improvements
Honor plotly figure's template dimensions
Closes #62 by honoring the width/height specifications stored in the plotly figure template.
(0fa6083)
Set default plotGlPixelRatio based on the scale factor
Addresses the Kaleido portion of #58 by setting the default value of
plotGlPixelRatioto twice the image scale factor. Note that not all of the WebGL plotly.js trace types honor this property yet (see plotly/plotly.js#5500 for work on that front)(42234c3)
Refactor JSON encoding to take advantage of future plotly.py performance enhancements
Refactors how plotly.py JSON encoding is performed to take advantage of the future JSON encoding performance enhancements coming in plotly.py version 5 (see plotly/plotly.py#2955)
(eb7dfb8)
Default AWS Lambda support
Add
--single-processchromium flag to default set when we detect that we're running on AWS Lambda. See #74. cc @carterthayer(fa3cd67)