Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

Missing plotly.js dependency in JS distribution #826

Closed
wbrgss opened this issue Jun 18, 2020 · 0 comments · Fixed by #836
Closed

Missing plotly.js dependency in JS distribution #826

wbrgss opened this issue Jun 18, 2020 · 0 comments · Fixed by #836
Assignees
Labels
dash-type-bug Something isn't working as intended size: 0.1

Comments

@wbrgss
Copy link
Contributor

wbrgss commented Jun 18, 2020

I have a project that relies on dash-core-components (https://www.npmjs.com/package/dash-core-components). When upgrading the module from 1.8.0 to 1.10.1 and rebuilding my project, I get the following error:

ERROR in ./node_modules/dash-core-components/lib/utils/LazyLoader/plotly.js
    Module not found: Error: Can't resolve 'plotly.js' in '/home/plotly/Workspace/{my_project}/node_modules/dash-core-components/lib/utils/LazyLoader'
     @ ./node_modules/dash-core-components/lib/utils/LazyLoader/plotly.js 9:42-11:14
     @ ./node_modules/dash-core-components/lib/components/Graph.react.js
     @ ./src/lib/components/Graph.react.generated.js
     @ ./src/lib/index.js

I resolved the error by doing npm i --save plotly.js in my project. I suspect this error arose from moving the plotly.js dependency from dependencies to devDependencies in this repo's package.json in PR #800. Was the move to devDependencies intentional @Marc-Andre-Rivet or can we safely move it back?

For now, I can simply take on the plotly.js dependency in my own project's package.json.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dash-type-bug Something isn't working as intended size: 0.1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants