This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 72
three new review / documentation / target apps #111
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see discussion in #108
lgtm! |
Marc-Andre-Rivet
approved these changes
Sep 25, 2018
cldougl
approved these changes
Sep 26, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
such nice explanations!!
tests/dash/app_sizing.py
Outdated
|
||
In this way, `min-width` and `overflow-x: scroll` is an alternative | ||
to `text-overflow: ellipses`. With scroll, the content that can't | ||
fit on the container will get pushed out into a scrollable zone. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe fit in the container instead of on
*** | ||
|
||
`Table` includes several features for modifying and transforming the | ||
view of the data. These include: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seeing this list is so helpful!!
tests/dash/app_sizing.py
Outdated
""" | ||
The widths can be under-specified. Here, we're only setting the width for the three | ||
columns in the middle, the rest of the columns are automatically sized to fit the rest of the container. | ||
The columns have a width of 50, or the width of this line: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps specify 50px in this text (to emphasize the static unit/prepare for variable %s)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#108 but with clean git history