3.1 issue137 centos setup #184
Conversation
Marc-Andre-Rivet
commented
Oct 30, 2018
Marc-Andre-Rivet
commented
- handling unicode chars for packages prop in setup.py
- adding dash dependency
| @@ -4,7 +4,7 @@ | |||
| with open('package.json') as f: | |||
| package = json.load(f) | |||
|
|
|||
| package_name = package["name"].replace(" ", "_").replace("-", "_") | |||
| package_name = str(package["name"].replace(" ", "_").replace("-", "_")) | |||
There was a problem hiding this comment.
The 3rd party library used by setuptools for the packages prop can't handle unicode characters.. casting through str(...) removed the unicode encoding and makes everything work.
There was a problem hiding this comment.
Figured it was something to do with the encoding, thanks for confirming it.
| @@ -14,5 +14,5 @@ | |||
| include_package_data=True, | |||
| license=package['license'], | |||
| description=package['description'] if 'description' in package else package_name, | |||
| install_requires=[] | |||
| install_requires=['dash'] | |||
There was a problem hiding this comment.
I've seen this dependency in other dash-* projects, let me know if there's a reason why it shouldn't be included here..
There was a problem hiding this comment.
It import dash in the __init__.py if that's like the other repos so it needs it.
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "dash-table", | |||
| "version": "3.1.0rc12", | |||
| "version": "3.1.0rc13", | |||
There was a problem hiding this comment.
bump version
…-setup # Conflicts: # CHANGELOG.md # dash_table/package.json # package.json
|
@T4rk1n Tagging for review. Thanks. |
| @@ -4,7 +4,7 @@ | |||
| with open('package.json') as f: | |||
| package = json.load(f) | |||
|
|
|||
| package_name = package["name"].replace(" ", "_").replace("-", "_") | |||
| package_name = str(package["name"].replace(" ", "_").replace("-", "_")) | |||
There was a problem hiding this comment.
Figured it was something to do with the encoding, thanks for confirming it.
| @@ -14,5 +14,5 @@ | |||
| include_package_data=True, | |||
| license=package['license'], | |||
| description=package['description'] if 'description' in package else package_name, | |||
| install_requires=[] | |||
| install_requires=['dash'] | |||
There was a problem hiding this comment.
It import dash in the __init__.py if that's like the other repos so it needs it.
