This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
Change component name to DataTable #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update usage & tests - bump version
| @@ -22,7 +22,7 @@ | |||
| "build:js-dev": "run-s \"private::build -- --mode development\"", | |||
| "build:js-test": "run-s \"private::build -- --config webpack.test.config.js\"", | |||
| "build:js-test-watch": "run-s \"private::build -- --config webpack.test.config.js --watch\"", | |||
| "build:py": "./extract-meta src/dash-table/Table.js > dash_table/metadata.json && cp package.json dash_table", | |||
| "build:py": "./extract-meta src/dash-table/DataTable.js > dash_table/metadata.json && cp package.json dash_table", | |||
There was a problem hiding this comment.
extract prop types from new file
| @@ -16,7 +16,7 @@ function isBackEnd(value) { | |||
| return ['be', false].indexOf(value) !== -1; | |||
| } | |||
|
|
|||
| export default class Table extends Component { | |||
| export default class DataTable extends Component { | |||
There was a problem hiding this comment.
changing class name to be consistent
| @@ -26,7 +26,7 @@ | |||
| app.layout = html.Div( | |||
| [ | |||
| html.Div(id="container", children="Hello World"), | |||
| dash_table.Table( | |||
| dash_table.DataTable( | |||
There was a problem hiding this comment.
Changing test usage
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "dash-table", | |||
| "version": "3.1.0rc16", | |||
| "version": "3.1.0-rc17", | |||
There was a problem hiding this comment.
bump version
chriddyp
approved these changes
Oct 31, 2018
…-table # Conflicts: # CHANGELOG.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #154.
Will require a follow up PR in dash-docs to update usage there as well once merged.