This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
Fix performance degradation #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marc-Andre-Rivet
commented
Nov 1, 2018
| @@ -37,6 +38,10 @@ export default class ControlledTable extends PureComponent<ControlledTableProps, | |||
| private readonly tableFn: () => JSX.Element[][]; | |||
| private readonly tableStyle = derivedTableStyle(); | |||
|
|
|||
| private calculateTableStyle = memoizeOne((style: Partial<IStyle>) => R.mergeAll( | |||
| this.tableStyle(DEFAULT_STYLE, style) | |||
| )); | |||
There was a problem hiding this comment.
style_table rarely changes, merging it with DEFAULT_STYLE creates a new object each time, triggering lots of re-renders and layout reevaluations. Memoizing the value prevents those problematic re-renders from occurring and brings performance back to what it used to be.
valentijnnieman
approved these changes
Nov 1, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #198