Skip to content
This repository has been archived by the owner on Jun 4, 2024. It is now read-only.

[WIP] Issue 216 - Fix alignment with vertical scroll #246

Closed
wants to merge 10 commits into from

Conversation

Marc-Andre-Rivet
Copy link
Contributor

@Marc-Andre-Rivet Marc-Andre-Rivet commented Nov 19, 2018

Fixes #216.

Windows 10 / Edge 17

With certain OS/browser combinations, the scrollbar is displayed beside the scrollable element, with others it's displayed inside the element. When displayed beside it, this causes the container of "content" portion of the table (vs. fixed rows) to be wider than the other container, causing misalignment and overlap when scrolled to the end.

Note: Need to review visual changes and to make sure how much the default behavior of the table is affected by this (does it still fill content when applicable?)

This:
image

Becomes:
image

@chriddyp chriddyp temporarily deployed to dash-table-review-pr-246 November 19, 2018 16:19 Inactive
@Marc-Andre-Rivet Marc-Andre-Rivet changed the title Issue 216 - Fix alignment with vertical scroll [WIP] Issue 216 - Fix alignment with vertical scroll Nov 19, 2018
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-246 November 19, 2018 16:46 Inactive
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-246 November 19, 2018 18:45 Inactive
- firefox percentage based columns
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-246 November 19, 2018 19:13 Inactive
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-246 November 20, 2018 00:42 Inactive
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-246 November 20, 2018 00:49 Inactive
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-246 November 20, 2018 00:56 Inactive
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-246 November 20, 2018 01:03 Inactive
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-246 November 20, 2018 01:38 Inactive
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Side scroll misalignment
2 participants