fix regression + new test #63
Conversation
| @@ -28,4 +28,9 @@ describe('dash basic', () => { | |||
| }); | |||
| }); | |||
| }); | |||
|
|
|||
| it('can get cell with double click', () => { | |||
| DashTable.getCell(3, 3).within(() => cy.get('div').dblclick()); | |||
There was a problem hiding this comment.
Not sure why I can click on the cell itself but need to dblclick on the child both handlers are defined on the cell itself... otherwise this does not work.
| @@ -62,6 +62,8 @@ | |||
| {'id': 12, 'name': 'Timely response?'}, | |||
| {'id': 13, 'name': 'Consumer disputed?'} | |||
| ], | |||
| n_fixed_columns=2, | |||
| n_fixed_rows=1, | |||
There was a problem hiding this comment.
Changing the test case to have fixed rows/columns as this is necessary for the bug to activate.
There was a problem hiding this comment.
The refactoring for fixed rows+columns introduced a regression on double click handling.
Modifying the code to do the same transform that's done on click.
Is this what is meant to happen? Because with this PR single click behaviour sets a cell to focused (i.e. highlighted), and a double click sets the cell to active (i.e. editable). I'm happy with this behaviour; it's what I suggested in #62. But this comment makes it a bit unclear, unless I'm misinterpreting the meaning of "transform".
|
afaik
is what we want to aim for |
|
afaik it's also what we want, this code's impact/logic was never touched. |
The refactoring for fixed rows+columns introduced a regression on double click handling.
Modifying the code to do the same transform that's done on click.
Adding one test for this case.