Skip to content
This repository has been archived by the owner on Jun 4, 2024. It is now read-only.

Attempt to fix incorrect tooltip placement #906

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

adament
Copy link

@adament adament commented May 31, 2021

This is an attempt to fix #872, the interpretation of the row value of currentTooltip was inconsistent across the codebase. In this patch I try to fix the row value to mean the row in the current displayed data which means that getSelectedTooltip needs to convert to the row number of the full dataset. It works for filtering and pagination in the demo application. However I have not tested with a proper virtualized dataset.

I have little to no experience with javascript, typescript or developing dash components so there is a great risk that I have overlooked something trivial.

Thank you very much for an amazing tool in dash table.

@adament
Copy link
Author

adament commented May 31, 2021

I am not really sure what is wrong with the lint or how to fix it, so any help would be greatly appreciated.

@alexcjohnson
Copy link
Collaborator

Thanks @adament - we'll need to dig into the virtualized case a bit to see it this still works. In order to properly lock down the fix as well as these other cases we'll want a couple of tests - probably test_tooltip.py is the right place as well as a good starting point to create the tests.

Re: linting - npm run format should fix it for you.

@tlinnet
Copy link

tlinnet commented Feb 21, 2022

Any update on this fix?

@akullenberg-cbp
Copy link

Can someone pick this up again?

@kenshima4
Copy link

Hi can I have a crack at this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip position is incorrect after sorting/filtering data table
5 participants