This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
Attempt to fix incorrect tooltip placement #906
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix #872, the interpretation of the row value of currentTooltip was inconsistent across the codebase. In this patch I try to fix the row value to mean the row in the current displayed data which means that getSelectedTooltip needs to convert to the row number of the full dataset. It works for filtering and pagination in the demo application. However I have not tested with a proper virtualized dataset.
I have little to no experience with javascript, typescript or developing dash components so there is a great risk that I have overlooked something trivial.
Thank you very much for an amazing tool in dash table.