Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes bug with whitespace on DataTable when merge_duplicate_header=True #2939

Merged
merged 4 commits into from
Oct 17, 2024
Merged

Fixes bug with whitespace on DataTable when merge_duplicate_header=True #2939

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bab36c9
Fixes bug with whitespace on DataTable when merge_duplicate_header=True
leeagustin Jul 5, 2024
0017806
Merge branch 'dev' into DataTable-whitespace-fix
T4rk1n Sep 3, 2024
801a33e
Merge branch 'dev' into DataTable-whitespace-fix
T4rk1n Oct 17, 2024
c0cd75b
Update changelog
T4rk1n Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ This project adheres to [Semantic Versioning](https://semver.org/).

## Fixed

- [#2939](https://github.com/plotly/dash/pull/2939) Fixes bug with whitespace on DataTable when `merge_duplicate_header=True`. Fixes [#2870](https://github.com/plotly/dash/issues/2870)
- [#2994](https://github.com/plotly/dash/pull/2994) Keep generated doc-string order for shape or exact props. Fixes [#2990](https://github.com/plotly/dash/issues/2990)
- [#3011](https://github.com/plotly/dash/pull/3011) Fixed an exception error caused by assigning `None` to array properties with `exact` or `shape` element types. Fixes [#3010](https://github.com/plotly/dash/issues/3010)
- [#2991](https://github.com/plotly/dash/pull/2991) Add support for URL decoding of the search parameter for pages.
Expand Down
2 changes: 1 addition & 1 deletion components/dash-table/src/dash-table/components/ControlledTable/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@ export default class ControlledTable extends PureComponent<ControlledTableProps>
if (fixed_columns || fixed_rows) {
const widths = Array.from(
r1c1.querySelectorAll(
'table.cell-table > tbody > tr:first-of-type > *'
'table.cell-table > tbody > tr:last-of-type > *'
)
).map(c => c.getBoundingClientRect().width);

Expand Down