Fix display of stack traces within RStudio's viewer pane #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 3, 2019 23:40
2 tasks
alexcjohnson
reviewed
Nov 5, 2019
dash-renderer/src/components/error/FrontEnd/FrontEndError.react.js
Outdated
Show resolved
Hide resolved
alexcjohnson
reviewed
Nov 5, 2019
| style={{ | ||
| width: 'calc(600px - 67px)', | ||
| height: '75vh', | ||
| border: 'none', |
There was a problem hiding this comment.
Do we actually need any of these style attrs?
There was a problem hiding this comment.
I kept them because we used them previously, but it might be ok to 🔪 from both R and Python. The important bits are in the FrontEndError.css file anyhow.
There was a problem hiding this comment.
The <iframe> needs explicit sizing because the containing page doesn't know what's in it, and border because perhaps iframes have a border by default. But the unframed string version should be closer to the front-end version, which gets most of its styling from .dash-fe-error__info.
…t.js Co-Authored-By: alexcjohnson <johnson.alex.c@gmail.com>
chriddyp
pushed a commit
that referenced
this pull request
Jan 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to modify
dash-rendererto check whether the stack trace being sent up by the backend includes the string<!DOCTYPE HTML. If it does, the content is embedded within aniframeto avoid CSS leaking caused by the Werkzeug HTML which Dash for Python provides.If it does not, the content is included in a simple nested
divinstead, with customized CSS to properly line-wrap the preformatted content, and to automatically use a scrollbar if the stack trace is sufficiently long.After merging, the stack trace within the dev tools UI for Dash for R apps will look like this:
To be merged concurrently with plotly/dashR#137. Fixes #994.