Add line number context to stack traces when srcrefs are available #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpkyle
added
parity
rpkyle
changed the title
alexcjohnson
approved these changes
Oct 17, 2019
rpkyle
added a commit
that referenced
this pull request
Nov 1, 2019
* Add line number context to stack traces when srcrefs are available (#133) * ✨ Support line #s when in debug mode * ✨ Add use_viewer option for RStudio * 🚨 Add soft and hard hot reloading tests
Merged
rpkyle
added a commit
that referenced
this pull request
Jan 4, 2020
* Provide support for no_update in Dash for R (#111) * Use dev_tools_prune_errors instead of pruned_errors (#113) * Better handling for user-defined error conditions in debug mode (#116) * Provide support for multiple outputs (#119) * Provide support for hot reloading in Dash for R (#127) * Implement support for clientside callbacks in Dash for R (#130) * Add line number context to stack traces when srcrefs are available (#133) * Update dash-renderer to 1.2.2 and fix dev tools UI display of stack traces (#137) * Support for meta tags in Dash for R (#142) * Fixes for hot reloading interval handling and refreshing apps within viewer pane (#148) * Support for asynchronous loading/compression in Dash for R (#157) * Support returning asset URLs via public method within Dash class (#160) * Minor fix for get_asset_url + docs, add url_base_pathname (#161)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to inspect
srcrefattributes, when available, for additional context whendebug=TRUEand errors are reported in the console or the dev tools UI in-browser. This information is populated in several settings:KeepSourceistruein the packageDESCRIPTIONfilesource()andkeep.source = TRUE(the default in most cases)Rscriptis used to invokesourceat the CLI, andkeep.source = TRUEis explicitly provided as an argument tosource(sincekeep.sourcedoes not default toTRUEin most cases)Some function calls will not have
srcrefattributes populated, and for these no line number is currently displayed. We will continue to investigate whether this functionality can be provided.The initially proposed implementation looks like this:
... and within the dev tools UI, it looks like this:
Since there are enclosing environments between the error handler within
getStackTraceand theprivatefield to whichstack_messageis passed, it is necessary to resolve the number of frames to ascend up the stack. The proposedcountEnclosingFramesfunction is an initial attempt at introducing this functionality.This PR also resolves an issue with the option to display apps within RStudio's viewer pane, and renames that option from
viewertouse_viewer.Closes #132. @chriddyp