Fixes for hot reloading interval handling and refreshing apps within viewer pane #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R/dash.R
Outdated
| else { | ||
| # determine if the time since last reload end is equal to or longer than the requested check interval | ||
| # (Sys.time() - private$last_reload) provides time in seconds, same units as hot_reload_watch_interval | ||
| permit_reload <- (Sys.time() - private$last_reload) >= hot_reload_watch_interval |
There was a problem hiding this comment.
This will work. But a common way to do it with only one variable is to start with private$last_reload = 0 or some known distant past time (0 often works for that purpose because it typically means the unix epoch = 1/1/1970)
alexcjohnson
approved these changes
Nov 18, 2019
Merged
rpkyle
added a commit
that referenced
this pull request
Jan 4, 2020
* Provide support for no_update in Dash for R (#111) * Use dev_tools_prune_errors instead of pruned_errors (#113) * Better handling for user-defined error conditions in debug mode (#116) * Provide support for multiple outputs (#119) * Provide support for hot reloading in Dash for R (#127) * Implement support for clientside callbacks in Dash for R (#130) * Add line number context to stack traces when srcrefs are available (#133) * Update dash-renderer to 1.2.2 and fix dev tools UI display of stack traces (#137) * Support for meta tags in Dash for R (#142) * Fixes for hot reloading interval handling and refreshing apps within viewer pane (#148) * Support for asynchronous loading/compression in Dash for R (#157) * Support returning asset URLs via public method within Dash class (#160) * Minor fix for get_asset_url + docs, add url_base_pathname (#161)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes several modifications to address issues noted in #146 and #147:
private$in_viewerfield tracks whether the app should be reloaded within RStudio's viewer paneapp_urlnow usesself$server$hostandself$server$portself$config$hot_reloadincorrectly usedhot_reload_watch_interval, this has been corrected tohot_reload_intervalpermit_reloadis alwaysTRUEuntil one reload event has occurred; on subsequent cycles, reloads are permitted if the current (wall) time is at leasthot_reload_watch_intervalseconds greater than the time stored inprivate$last_reloadResolves #146, fixes #147.