Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for meta tags in Dash for R #142

Merged
merged 9 commits into from
Nov 5, 2019
Merged

Support for meta tags in Dash for R #142

merged 9 commits into from
Nov 5, 2019

Conversation

rpkyle
Copy link
Contributor

@rpkyle rpkyle commented Nov 4, 2019

This PR proposes to add support for <meta> tags to Dash for R applications, as previously provided in Dash for Python via plotly/dash#286.

The newly added generate_meta_tags function will also check whether http-equiv provides the value X-UA-Compatible and add it for IE compatibility if it is not present. Similarly, if no character set is specified, UTF-8 is chosen.

@jackparmer

@rpkyle rpkyle added enhancement high priority parity Modifications to improve parity across Dash implementations size: 1 dash-stage-in_review labels Nov 4, 2019
@rpkyle rpkyle added this to the Dash v1.6 milestone Nov 4, 2019
@rpkyle rpkyle self-assigned this Nov 4, 2019
R/utils.R Outdated Show resolved Hide resolved
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 just a couple more quick pieces I'd like to see in the new tests, aside from that this is looking great!

R/dash.R Outdated Show resolved Hide resolved
@Marc-Andre-Rivet Marc-Andre-Rivet modified the milestones: Dash v1.6, Dash v1.7 Nov 5, 2019
@rpkyle rpkyle merged commit f866d38 into dev Nov 5, 2019
@rpkyle rpkyle deleted the 141-meta-tags branch November 5, 2019 16:18
@rpkyle rpkyle mentioned this pull request Jan 3, 2020
rpkyle added a commit that referenced this pull request Jan 4, 2020
* Provide support for no_update in Dash for R (#111)

* Use dev_tools_prune_errors instead of pruned_errors (#113)

* Better handling for user-defined error conditions in debug mode (#116)

* Provide support for multiple outputs (#119)

* Provide support for hot reloading in Dash for R (#127)

* Implement support for clientside callbacks in Dash for R (#130)

* Add line number context to stack traces when srcrefs are available (#133)

* Update dash-renderer to 1.2.2 and fix dev tools UI display of stack traces (#137)

* Support for meta tags in Dash for R (#142)

* Fixes for hot reloading interval handling and refreshing apps within viewer pane (#148)

* Support for asynchronous loading/compression in Dash for R (#157)

* Support returning asset URLs via public method within Dash class (#160)

* Minor fix for get_asset_url + docs, add url_base_pathname (#161)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement high priority parity Modifications to improve parity across Dash implementations size: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants