Configure Project for Electron-Builder #52
Conversation
test/common.js
Outdated
|
|
||
| const paths = {} | ||
| const urls = {} | ||
| const mocks = {} | ||
|
|
||
| paths.root = path.join(__dirname, '..') | ||
| paths.build = path.join(paths.root, 'build') | ||
| paths.build = path.join(os.tmpdir(), 'plotly-graph-exporter-build') |
There was a problem hiding this comment.
Can we keep build/ for testing stuff. This will help debug on CI by more easily inspecting test artefacts.
There was a problem hiding this comment.
Okay, if you would like.
There was a problem hiding this comment.
I will do this next week, unless otherwise requested.
There was a problem hiding this comment.
Next week sounds good. Thank you!
There was a problem hiding this comment.
Okay, I should have this fixed tomorrow!
| @@ -22,7 +22,7 @@ tap.test('pdftops.pdf2eps', t => { | |||
| if (err) t.fail(err) | |||
|
|
|||
| const size = fs.statSync(outPath).size | |||
| t.ok(size > 1e5, 'min pdf file size') | |||
| t.ok(size > 9e4, 'min pdf file size') | |||
There was a problem hiding this comment.
This resolves #48 I presume? Nice!
| "mac": { | ||
| "target": [{ | ||
| "target": "default" | ||
| }]} |
There was a problem hiding this comment.
Would you mind adding Linux deb target so that I can test it on my laptop? (Sorry for the inconvenience if any),
There was a problem hiding this comment.
I have Ubuntu as the main OS on my laptop, which is a Debian distribution. AppImage is the default format for this build target. If one runs electron-builder . or similar, one would get an AppImage which one can execute on Debian.
If you require me to address this further, let me know.
|
Excellent use of Great contribution 👌 I made one blocking comment: where I think we should keep I can take care (and probably should 😉 ) of other one about making an Debian built myself. |
|
Thank you for the kind words, @etpinard. |
…help debug on CI by more easily inspecting test artefacts."
|
Hello, all! Last we discussed this pull request, @etpinard wrote:
I have just pushed a commit which does just that. Shall we now merge this branch? |
|
Great! This PR is a big win 💃 (that means good to merge in plotly lingo that predates github PR review) Would you opening up an issue about trying to build this thing for Linux, so that we don't forget about #52 (comment) |
Hello all,
Note that this pull request is not necessarily a "request to pull," but rather serves also to demonstrate my actions thus far, and to facilitate discussion.
This PR grants the building of native Electron apps for *nix, Windows and OS X targets, via
and similar.
This PR grants the ability to use the Python Graph Exporter shell tool, via (example, *nix version)
The AppImage target is a standalone executable, ~50MB.
All test pass.
Using
/buildthe way it was done, is no longer possible with standard (even non-compiled) Electron-Builder settings, so I changed all references to point to a cross-platform tempdir.―James
NB: I know I was given access to the blank https://github.com/plotly/python-image-exporter with the goal of keeping packaging concerns separate from feature concerns, however that has not proven to be possible (yet?) due to the tempdir architectural concern.