Enable CI platforms to build Linux, Windows and OS X releases #63
Conversation
… roughly 50% of the time
|
To my knowledge, no issues raised are presently unaddressed by me, nor is "the ball in my court" regarding any discussion subthreads on this pull request. |
package.json
Outdated
| @@ -43,6 +60,7 @@ | |||
| "plotly" | |||
| ], | |||
| "dependencies": { | |||
| "ajv": "^6.4.0", | |||
There was a problem hiding this comment.
@etpinard Adding this dependency resolved this error: ajv-validator/ajv#708. If you like to learn more, you might start at npm/npm#19877. I admit I have only cursorily glanced at it. More importantly, I got the above AJV error, and I fixed it by adding this explicit dependency (it was presumably already an implicit dependency).
Hope that explains things. Let me know if you have additional questions or thoughts about it.
There was a problem hiding this comment.
@JamesCropcho but we don't use ajv-keyword, do we?
There was a problem hiding this comment.
I forgot about Étienne's comment: we should remove
ajvfrom the deps.
Okay, I have done so, and the previous error is no longer present.
|
Looking good except for that |
|
@etpinard @JamesCropcho How about merging |
…here wouldn't be a chance of getting that missing image error."
It would be best to double-check with the docker-push step author @scjody before making a change like this. |
Okay, I have done this. |
|
The reason Has anyone looked into the "missing image" error? It might be worth talking to CircleCI support if it happens consistently. Also while I'm here, I know @etpinard isn't big on rebases but I strongly suggest cleaning up the commit history of this PR before merging. It's up to you folks though. |
Yes, we should absolutely rebase these commits here. |
Squash and merge? |
|
My preference would be to rebase this down to 10 or so well thought out and understandable commits, which will increase the usefulness of our git history (especially on existing files) vs. squashing. However I realize that may be a significant amount of work and I'm not strongly against squashing. |
|
Repost #63 (comment)
|
I personally have not. I can talk to CircleCI support about it upon request, although I don't believe I would be best-qualified to do so. Also, I would be loathe to make this task a blocking issue for pull request acceptance. |
|
Ok. Having talking to @scjody , merging docker-build and docker-push into one job isn't that big of a deal for now. Before the merger our total CI time was around 6 minutes, after the merged it is more like 8 minutes. Those two extra minutes is hardly worth time and effort at this stage. Issue logged in -> #68 |
|
Squashing and merging. Great job @JamesCropcho with special thanks to @n-riesco for the help! |
|
Thank you the kind words, @etpinard! I'm very happy to see this branch being merged into |
Hello all,
This would enable the CI platforms to build a cross-platform set of releases:
These releases have not been tested on their respective platforms, nor are they necessarily in their final format. However, this pull would indeed enable some form of successful build for each of the three platforms we are targeting.
What do you all think?
―James