Toby ylim #171
Merged
Toby ylim #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mkcor @chriddyp @cpsievert I updated the test table and saw no regressions I added this new test which now passes (error on master) please code review |
| "date" | ||
| }else{ | ||
| stop("unrecognized data type for ", xy, " axis") | ||
| } |
There was a problem hiding this comment.
💄 - spaces around if:
, space between } and else
|
cool! besides that super minor style issue, all good from me. bump version and 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this branch has a small fix for using ylim in one of the #161 examples
http://www.cookbook-r.com/Graphs/Bar_and_line_graphs_%28ggplot2%29/line-point-ylim.png