-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise textposition default for bar, histogram and waterfall #5638
Conversation
Looking particularly at the histogram-offsetgroups mock, I'm wondering if we shouldn't be a little more nuanced about this: if We have no such logic for scatter, but in that case it's fairly common to want all markers in a trace to get the same text - the text may even BE the marker. I could could go either way on this, just wanted to throw it out there. The "always auto" logic is nice for its simplicity, and I'd do it this way if starting fresh, it just may break more graphs than we would need to with the v2 upgrade. @nicolaskruchten @archmoj thoughts? |
I can see what you mean, but this seems like really edge-case behaviour, probably used in cases where folks didn't want to rename the trace or something? Sure, let's carve something out for that. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, thinking about this more, especially with all the other work we're doing to simplify defaults for v2, making this conditional default seems like a step backward.
So to me this is good to go 💃 unless @nicolaskruchten wants to argue for sticking with my previous suggestion 😅
I'm good, please merge :) |
Resolves #5624.
@plotly/plotly_js