Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load maki icon #7068

Merged
merged 5 commits into from
Jul 26, 2024
Merged

Conversation

birkskyum
Copy link
Contributor

@birkskyum birkskyum commented Jul 26, 2024

@archmoj, links to icons/sprites are usually inside the style.json itself, but for compatibility if a maki icon (gh repo) is detected as missing, this PR will make sure it's downloaded and rendered.

Screenshot 2024-07-26 at 19 02 23

@birkskyum birkskyum mentioned this pull request Jul 26, 2024
@archmoj archmoj added bug something broken community community contribution status: reviewable labels Jul 26, 2024
@archmoj
Copy link
Contributor

archmoj commented Jul 26, 2024

Thanks very much for the PR.
Please download & update new baselines from https://app.circleci.com/pipelines/github/plotly/plotly.js/10929/workflows/4bdb5573-f32a-4762-97d1-054c349c9dfd/jobs/240837/artifacts

@birkskyum
Copy link
Contributor Author

You're very welcome. They are update now.

@archmoj
Copy link
Contributor

archmoj commented Jul 26, 2024

When comparing the diffs here https://github.com/plotly/plotly.js/pull/7015/files#diff-f0fbe3130eb2e4f0e1c8faf5ba166a839a3dfdce358c2e60d6f9c8ee5ccf475b
I see a lighter color being used on the mapbox baselines.
But the symbols here show in black!
Does marker.color work?

@birkskyum
Copy link
Contributor Author

@archmoj setting marker.color: '#ffff00', (yellow) appear to change the color of the line between the icons for both mapbox/maplibre.

@birkskyum
Copy link
Contributor Author

This is an area where both mapbox/maplibre are too strict. We're planning to add proper SVG support, which would make things easier to style and improve in other areas too - maplibre/maplibre#175.

@archmoj
Copy link
Contributor

archmoj commented Jul 26, 2024

Please add 'map_angles' to isOtherFlaky list in test/image/compare_pixels_test.js.
Thank you!

@archmoj
Copy link
Contributor

archmoj commented Jul 26, 2024

💃
Thanks very much.
FYI I'll fix the b64 image test on my PR.

@archmoj archmoj merged commit 096b347 into plotly:add-maplibre-option Jul 26, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken community community contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants