-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
load maki icon #7068
load maki icon #7068
Conversation
Thanks very much for the PR. |
You're very welcome. They are update now. |
When comparing the diffs here https://github.com/plotly/plotly.js/pull/7015/files#diff-f0fbe3130eb2e4f0e1c8faf5ba166a839a3dfdce358c2e60d6f9c8ee5ccf475b |
@archmoj setting |
This is an area where both mapbox/maplibre are too strict. We're planning to add proper SVG support, which would make things easier to style and improve in other areas too - maplibre/maplibre#175. |
Please add |
💃 |
@archmoj, links to icons/sprites are usually inside the style.json itself, but for compatibility if a maki icon (gh repo) is detected as missing, this PR will make sure it's downloaded and rendered.