Skip to content

Commit d2af541

Browse files
authored
Merge pull request #5258 from plotly/fix-default-renderer-when-ipython-installed
Fix issue with default renderer when `ipython` is installed
2 parents aa4c088 + 75ae9d3 commit d2af541

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

plotly/io/_renderers.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -485,7 +485,7 @@ def show(fig, renderer=None, validate=True, **kwargs):
485485
)
486486

487487
default_renderer = env_renderer
488-
elif ipython:
488+
elif ipython and ipython.get_ipython():
489489
# Try to detect environment so that we can enable a useful
490490
# default renderer
491491
if not default_renderer:

tests/test_io/test_renderers.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,13 @@ def fig1(request):
3333
)
3434

3535

36+
def test_default_renderer():
37+
"""
38+
The default renderer should be 'browser'.
39+
"""
40+
assert pio.renderers.default == "browser"
41+
42+
3643
# JSON
3744
# ----
3845
def test_json_renderer_mimetype(fig1):

0 commit comments

Comments
 (0)