Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX selector = 0 returns all traces in select_traces #3817

Merged
merged 4 commits into from
Jan 4, 2023
Merged

FIX selector = 0 returns all traces in select_traces #3817

merged 4 commits into from
Jan 4, 2023

Conversation

wf-r
Copy link
Contributor

@wf-r wf-r commented Jul 19, 2022 •
edited

Fix #3639 (selector = 0 in update_traces selects all traces, not only the first one)

Code PR

  • I have read through the contributing notes and understand the structure of the package. In particular, if my PR modifies code of plotly.graph_objects, my modifications concern the codegen files and not generated files.
  • I have added tests (if submitting a new feature or correcting a bug) or
    modified existing tests.

@wf-r
Copy link
Contributor Author

wf-r commented Jul 20, 2022

Hmm, I cannot connect the failed test with my changes. Anybody an idea?

@nicolaskruchten
Copy link
Member

Thanks!

@nicolaskruchten nicolaskruchten merged commit a8a0c9b into plotly:master Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

select_traces returns all traces when selector=0
2 participants
@wf-r @nicolaskruchten