-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infrastructure maintenance #2313
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plouc
force-pushed
the
infrastructure-maintenance
branch
from
April 28, 2023 21:00
fdd90e4
to
ce7fe85
Compare
This was referenced Apr 28, 2023
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 332908f:
|
…d storybook on CI
This was referenced Apr 30, 2023
Closed
This was referenced May 21, 2024
This was referenced Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While being able to run storybook without the need to compile the packages was nice, it was a pain to get it to work with rollup, and we ended up having 2 ways to compile the packages. Also all storybook dependencies were at the root, it's saner/simpler this way IMHO. It'll also allow us to upgrade things independently.
There's still some work to do to properly support React 18, but at least we can experience the issues 😅
4.5.4
->4.9.5
and fix typing issues.transformIgnorePatterns
to work with pnpm: https://jestjs.io/docs/configuration#transformignorepatterns-arraystring (due to some D3 packages being esm only).pkg|pkgs
.enzyme
is problematic with React 18 as it's not supported, we'll need to figure out a strategy for testing, tests still work, but with a bunch of warnings.