Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infrastructure maintenance #2313

Merged
merged 77 commits into from
Apr 30, 2023
Merged

Infrastructure maintenance #2313

merged 77 commits into from
Apr 30, 2023

Conversation

plouc
Copy link
Owner

@plouc plouc commented Apr 28, 2023

  • Migrate to pnpm.
  • Upgrade rollup.
  • Remove UMD builds as I could never get them to work properly, and they don't seem to be used.
  • Fix dependencies, as pnpm is stricter regarding deps, I realized several ones were missing, also related:
  • Isolate stories in a separate folder/project.
    While being able to run storybook without the need to compile the packages was nice, it was a pain to get it to work with rollup, and we ended up having 2 ways to compile the packages. Also all storybook dependencies were at the root, it's saner/simpler this way IMHO. It'll also allow us to upgrade things independently.
  • Upgrade storybook and migrate all existing stories to the new format.
  • Force the use of React 18 within the repo, the packages constraints still support older versions.
    There's still some work to do to properly support React 18, but at least we can experience the issues 😅
  • Upgrade TypeScript: 4.5.4 -> 4.9.5 and fix typing issues.
  • Adjust jest transformIgnorePatterns to work with pnpm: https://jestjs.io/docs/configuration#transformignorepatterns-arraystring (due to some D3 packages being esm only).
  • Make targets for packages were all renamed to pkg|pkgs.
  • Upgrade eslint.
  • Upgrade prettier.
  • The use of enzyme is problematic with React 18 as it's not supported, we'll need to figure out a strategy for testing, tests still work, but with a bunch of warnings.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 30, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 332908f:

Sandbox Source
nivo Configuration

@plouc plouc marked this pull request as ready for review April 30, 2023 16:53
@plouc plouc merged commit 0828cd7 into master Apr 30, 2023
@plouc plouc deleted the infrastructure-maintenance branch April 30, 2023 16:55
This was referenced Apr 30, 2023
@plouc plouc mentioned this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant