Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace MDI icons due to breaking changes in Nerd Fonts #73

Merged
merged 8 commits into from
May 11, 2023

Conversation

romantech
Copy link
Contributor

@romantech romantech commented May 10, 2023

Fixes

Fixes #72 by @romantech

Description

20230511_035740

  • Change all Nerd Font icons that start with the nf-mdi prefix
  • Change icon name comments for the changed icons
Icon Name From To
audio \ufc1d \uf1c7
broom \uf5e1 \ue615
git \uf7a1 \uf47f
python \uf81f \ue73c
runner \ufc0c \ueb7b
shell \ufcb5 \uf489
source \uf668 \uf1c9
test \ufb67 \uea79
video \ufa66 \uf1c8
audio \ufc1d \uf1c7
vuejs \ufd42 \ue6a0

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

The changes in this commit only affect the formatting of the file. The addition of whitespace makes the file easier to read and understand.
Copy link
Collaborator

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reporting, and fixing the issue @romantech. I appreciate you painstakingly finding replacements for all the MDI icons.

I have some recommended changes to the default set and I hope you won't mind. You can always override the defaults to your preferred icons via the .pls.yml config.

src/pls/data/nerd_icons.yml Outdated Show resolved Hide resolved
src/pls/data/nerd_icons.yml Outdated Show resolved Hide resolved
src/pls/data/nerd_icons.yml Outdated Show resolved Hide resolved
src/pls/data/nerd_icons.yml Outdated Show resolved Hide resolved
src/pls/data/nerd_icons.yml Outdated Show resolved Hide resolved
src/pls/data/nerd_icons.yml Outdated Show resolved Hide resolved
src/pls/data/nerd_icons.yml Outdated Show resolved Hide resolved
romantech and others added 6 commits May 11, 2023 05:43
Co-authored-by: Dhruv Bhanushali <dhruv_b@live.com>
Co-authored-by: Dhruv Bhanushali <dhruv_b@live.com>
Co-authored-by: Dhruv Bhanushali <dhruv_b@live.com>
Co-authored-by: Dhruv Bhanushali <dhruv_b@live.com>
Co-authored-by: Dhruv Bhanushali <dhruv_b@live.com>
Co-authored-by: Dhruv Bhanushali <dhruv_b@live.com>
@romantech
Copy link
Contributor Author

romantech commented May 10, 2023

Thanks for reporting, and fixing the issue @romantech. I appreciate you painstakingly finding replacements for all the MDI icons.

I have some recommended changes to the default set and I hope you won't mind. You can always override the defaults to your preferred icons via the .pls.yml config.

Thank you for your suggestion. As I had set the replacement icon arbitrarily, the alternative icon you proposed seems more suitable. Thank you.

@romantech romantech requested a review from dhruvkb May 10, 2023 20:52
@dhruvkb dhruvkb changed the title Change the Nerd Font icons starting with the nf-mdi prefix Replace MDI icons due to breaking changes in Nerd Fonts May 11, 2023
@dhruvkb dhruvkb merged commit 4465cbd into pls-rs:main May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to change the Nerd Font icons that starts with the nf-mdi prefix
2 participants